Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37459 )
Change subject: hatch: Fix FPMCU pwr/rst gpio handling
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37459/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37459/2//COMMIT_MSG@20
PS2, Line 20:
Oh, I thought we were avoiding ChromeOS specific references. […]
No, that is fine for coreboot reviews.
https://review.coreboot.org/c/coreboot/+/37459/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/37459/2/src/mainboard/google/hatch/...
PS2, Line 414: 1
Ahh, okay. I think I understand what https://review.coreboot.org/c/coreboot/+/32111 is doing now. […]
Aah I remember now. Yes, as long as it is configured as GPO, it should be fine then. Thanks for checking Craig!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37459
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e3ff42715611d519677a4256bdd172ec98687f9
Gerrit-Change-Number: 37459
Gerrit-PatchSet: 3
Gerrit-Owner: Craig Hesling
hesling@chromium.org
Gerrit-Reviewer: Craig Hesling
hesling@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 04 Dec 2019 23:42:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Craig Hesling
hesling@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment