Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33155 )
Change subject: drivers/wifi: Add generic WiFi driver ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/#/c/33155/4/src/drivers/intel/wifi/chip.h File src/drivers/intel/wifi/chip.h:
https://review.coreboot.org/#/c/33155/4/src/drivers/intel/wifi/chip.h@19 PS4, Line 19: #include "drivers/wifi/generic_wifi.h" Why?
https://review.coreboot.org/#/c/33155/4/src/drivers/wifi/generic.c File src/drivers/wifi/generic.c:
https://review.coreboot.org/#/c/33155/4/src/drivers/wifi/generic.c@230 PS4, Line 230: const char *generic_wifi_acpi_name(const struct device *dev) No we need unique names in case of multiple devices present?
https://review.coreboot.org/#/c/33155/4/src/drivers/wifi/generic_wifi.h File src/drivers/wifi/generic_wifi.h:
https://review.coreboot.org/#/c/33155/4/src/drivers/wifi/generic_wifi.h@25 PS4, Line 25: unsigned int wake; The name could be better than 'wake' but that is easy fix for followup if we decide so.