[coreboot-gerrit] [XS] Change in coreboot[main]: vc/amd/opensil/genoa_poc/mpio: simplify per_device_config arguments

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81341?usp=email )

Change subject: vc/amd/opensil/genoa_poc/mpio: simplify per_device_config arguments
......................................................................

vc/amd/opensil/genoa_poc/mpio: simplify per_device_config arguments

Since we're already passing a pointer to the corresponding device to
per_device_config, we don't need to pass the chip_info as separate
parameter. Before moving the PCIe port function device below the MPIO
chip, the chip_info struct was from a different device, so that change
allows this simplification.

Signed-off-by: Felix Held 
Change-Id: I0466f7ad2f5c9874d45712fa9f89b978bd2a09bc
Reviewed-on: https://review.coreboot.org/c/coreboot/+/81341
Tested-by: build bot (Jenkins) 
Reviewed-by: Arthur Heymans 
Reviewed-by: Varshit Pandya 
---
M src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Arthur Heymans: Looks good to me, approved
  build bot (Jenkins): Verified
  Varshit Pandya: Looks good to me, approved

diff --git a/src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c b/src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c
index 6d811ce..cae9d4b 100644
--- a/src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c
+++ b/src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c
@@ -125,12 +125,12 @@
    mpio_data->EarlyBmcLinkDie                     = 0;
 }

-static void per_device_config(MPIOCLASS_INPUT_BLK *mpio_data, struct device *dev,
-			      struct vendorcode_amd_opensil_genoa_poc_mpio_config *const config)
+static void per_device_config(MPIOCLASS_INPUT_BLK *mpio_data, struct device *dev)
 {
    static uint32_t slot_num;
    const uint32_t domain = dev->upstream->dev->path.domain.domain;
    const uint32_t devfn = dev->path.pci.devfn;
+	const struct vendorcode_amd_opensil_genoa_poc_mpio_config *const config = dev->chip_info;
    printk(BIOS_DEBUG, "Setting MPIO port for domain 0x%x, PCI %d:%d\n",
           domain, PCI_SLOT(devfn), PCI_FUNC(devfn));

@@ -198,5 +198,5 @@
    for (struct device *dev = &dev_root; dev; dev = dev->next)
    	if (dev->chip_ops == &vendorcode_amd_opensil_genoa_poc_mpio_ops &&
    	    dev->chip_info != dev->upstream->dev->chip_info)
-			per_device_config(mpio_data, dev, dev->chip_info);
+			per_device_config(mpio_data, dev);
 }