Taniya Das has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39612 )
Change subject: sc7180: clock: Add display external clock in coreboot ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39612/1/src/soc/qualcomm/sc7180/clo... File src/soc/qualcomm/sc7180/clock.c:
https://review.coreboot.org/c/coreboot/+/39612/1/src/soc/qualcomm/sc7180/clo... PS1, Line 365: static void * mdss_clock_get_reg_addr(const char *clk_name,
"foo * bar" should be "foo *bar"
Done
https://review.coreboot.org/c/coreboot/+/39612/1/src/soc/qualcomm/sc7180/clo... PS1, Line 381: else if(mdss_clk_type == 1)
space required before the open parenthesis '('
Done
https://review.coreboot.org/c/coreboot/+/39612/1/src/soc/qualcomm/sc7180/inc... File src/soc/qualcomm/sc7180/include/soc/clock.h:
https://review.coreboot.org/c/coreboot/+/39612/1/src/soc/qualcomm/sc7180/inc... PS1, Line 47: ((offsetof(type, mem)) + base)
code indent should use tabs where possible
Done