Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34603 )
Change subject: mb/asus: Add ASUS H110M-E/M.2 mainboard ......................................................................
Patch Set 83:
(12 comments)
Please, don't just copy and paste things around...
https://review.coreboot.org/c/coreboot/+/34603/83/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/34603/83/src/mainboard/asus/h110m-e... PS83, Line 1: GPL-2.0-or-later GPL-2.0-only
https://review.coreboot.org/c/coreboot/+/34603/83/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/34603/83/src/mainboard/asus/h110m-e... PS83, Line 1: GPL-2.0-or-later GPL-2.0-only
https://review.coreboot.org/c/coreboot/+/34603/83/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/bootblock.c:
https://review.coreboot.org/c/coreboot/+/34603/83/src/mainboard/asus/h110m-e... PS83, Line 1: GPL-2.0-or-later GPL-2.0-only
https://review.coreboot.org/c/coreboot/+/34603/83/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/cmos.layout:
https://review.coreboot.org/c/coreboot/+/34603/83/src/mainboard/asus/h110m-e... PS83, Line 1: GPL-2.0-or-later GPL-2.0-only
https://review.coreboot.org/c/coreboot/+/34603/83/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34603/83/src/mainboard/asus/h110m-e... PS83, Line 1: GPL-2.0-or-later GPL-2.0-only
https://review.coreboot.org/c/coreboot/+/34603/83/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/34603/83/src/mainboard/asus/h110m-e... PS83, Line 1: GPL-2.0-or-later GPL-2.0-only
https://review.coreboot.org/c/coreboot/+/34603/83/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/34603/83/src/mainboard/asus/h110m-e... PS83, Line 27: AZALIA_SUBVENDOR(0, 0x10438445), AZALIA_PIN_CFG(0, 0x11, 0x40000000), What happened here? Why aren't the AZALIA_PIN_CFG statements on a single line?
https://review.coreboot.org/c/coreboot/+/34603/83/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/include/gpio.h:
https://review.coreboot.org/c/coreboot/+/34603/83/src/mainboard/asus/h110m-e... PS83, Line 1: later The original file was never GPL-2.0-or-later, it was GPL-2.0-only
https://review.coreboot.org/c/coreboot/+/34603/83/src/mainboard/asus/h110m-e... PS83, Line 4: This file is part of the coreboot project. Only keep this line of the entire comment block.
/* This file is part of the coreboot project. */
Please do this for ALL files
https://review.coreboot.org/c/coreboot/+/34603/83/src/mainboard/asus/h110m-e... PS83, Line 19: _GPIO_DVS_H This symbol was from the H110M-DVS. Maybe change it to match your board?
https://review.coreboot.org/c/coreboot/+/34603/83/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/ramstage.c:
https://review.coreboot.org/c/coreboot/+/34603/83/src/mainboard/asus/h110m-e... PS83, Line 1: GPL-2.0-or-later GPL-2.0-only
https://review.coreboot.org/c/coreboot/+/34603/83/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/romstage.c:
https://review.coreboot.org/c/coreboot/+/34603/83/src/mainboard/asus/h110m-e... PS83, Line 1: GPL-2.0-or-later GPL-2.0-only