[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Add ability to disable Heci1

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32992 )

Change subject: soc/intel/cannonlake: Add ability to disable Heci1
......................................................................

Patch Set 13:

(1 comment)

https://review.coreboot.org/#/c/32992/13/src/soc/intel/cannonlake/fsp_params... 
File src/soc/intel/cannonlake/fsp_params.c:

https://review.coreboot.org/#/c/32992/13/src/soc/intel/cannonlake/fsp_params... 
PS13, Line 344:  !CONFIG(SOC_INTEL_COMETLAKE)
> In that case, the check here does not look right to me i.e. […]

yes, if its due to FSP UPD doesn't exist today for CML ?

#if CONFIG(SOC_INTEL_WHISKEYLAKE)