Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37478 )
Change subject: libpayload: Cache physical cbmem console address
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37478/1/payloads/libpayload/drivers...
File payloads/libpayload/drivers/cbmem_console.c:
https://review.coreboot.org/c/coreboot/+/37478/1/payloads/libpayload/drivers...
PS1, Line 60: just keep the physical address which won't break on relocation. */
Oh okay, yeah, then all this makes a bit more sense. […]
Resolved by keeping physical pointers in sysinfo.
https://review.coreboot.org/c/coreboot/+/37478/1/payloads/libpayload/drivers...
PS1, Line 64: cbmem_console_p
At the end of the train, it's all physical pointers now. Let me know […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37478
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4b8434af69e0526f78523ae61981a15abb1295b0
Gerrit-Change-Number: 37478
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Reto Buerki
reet@codelabs.ch
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 18 Aug 2020 10:18:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment