Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/20913 )
Change subject: mb/lenovo/x200: Add ACPI methods to set battery thresholds ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/20913/4/src/mainboard/lenovo/x200/acpi/bat_t... File src/mainboard/lenovo/x200/acpi/bat_thresh.asl:
https://review.coreboot.org/#/c/20913/4/src/mainboard/lenovo/x200/acpi/bat_t... PS4, Line 34: /* SetBatteryCharge Start/Stop Capacity Threshold : * In Parameter: : * DWORD : * Bit 7-0: Charge stop capacity (Unit:%) : * =0: Use battery default setting : * =1-99: Threshold to stop charging battery (Relative capacity) : * Bit 9-8:BatteryID : * = 0: Any battery : * = 1: Primary battery : * = 2: Secondary battery : * = Others: Reserved (0) : * Bit 31-10: Reserved (0) : * Must be Zero : * : * Out Parameter: : * DWORD : * Bit 30-0: Reserved (0) : * Bit 31: Error status : * 0 ... Success : * 1 ... Fail : */ These comments are taken from the tpacpi-bat (https://github.com/teleshoes/tpacpi-bat) project documentation which afaict is GPL3. IANAL so is this acceptable or does it need a rewrite?