Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40765 )
Change subject: Makefile: Add is-power-of-two
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40765/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40765/4//COMMIT_MSG@10
PS4, Line 10: two at build time. This adds a `make` function `is-power-of-two`.
I left a comment on CB:40808. The use-case is (indirectly) on C_ENV_BOOTBLOCK_SIZE and it can be handled by runtime alignment. And there is some motivation (on other than picasso, at least) to remove static C_ENV_BOOTBLOCK_SIZE Kconfig altogether.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40765
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I189a4c722996279e2d8940c566cb362f53ef92d8
Gerrit-Change-Number: 40765
Gerrit-PatchSet: 4
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 25 May 2020 14:11:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment