Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34884 )
Change subject: superio/ite/it8728f: hook up power_on_after_fail
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/34884/1/src/superio/ite/it8728f/sup...
File src/superio/ite/it8728f/superio.c:
https://review.coreboot.org/c/coreboot/+/34884/1/src/superio/ite/it8728f/sup...
PS1, Line 30: #define MAINBOARD_POWER_KEEP 2
These defines are currently scattered all around the source tree. […]
this could also be changed into an enum instead of a number of defines
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34884
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia06dbbbed32ba13c2d91efa6377986db8452b3f4
Gerrit-Change-Number: 34884
Gerrit-PatchSet: 1
Gerrit-Owner: James
jye836@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: James
jye836@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 15 Aug 2019 19:56:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: James
jye836@gmail.com
Gerrit-MessageType: comment