Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38341 )
Change subject: soc/intel/tigerlake: Update pci dev definition ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38341/5/src/soc/intel/tigerlake/chi... File src/soc/intel/tigerlake/chip.c:
https://review.coreboot.org/c/coreboot/+/38341/5/src/soc/intel/tigerlake/chi... PS5, Line 74: GFX0
Not used in TGL ASL, delete in https://review.coreboot. […]
Ack
https://review.coreboot.org/c/coreboot/+/38341/5/src/soc/intel/tigerlake/chi... PS5, Line 75: ISHB
Not used in TGL ASL, delete in https://review.coreboot. […]
Ack
https://review.coreboot.org/c/coreboot/+/38341/7/src/soc/intel/tigerlake/fin... File src/soc/intel/tigerlake/finalize.c:
https://review.coreboot.org/c/coreboot/+/38341/7/src/soc/intel/tigerlake/fin... PS7, Line 78: pch_thermal_configuration();
This function is INTEL_COMMON_BLOCK_THERMAL code.
Resolve compile issue by https://review.coreboot.org/c/coreboot/+/38444/2/src/soc/intel/skylake/final... So, revert this change