build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46290 )
Change subject: device/i2c_bus: Add i2c_dev_writeb_at16() ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46290/1/src/device/i2c_bus.c File src/device/i2c_bus.c:
https://review.coreboot.org/c/coreboot/+/46290/1/src/device/i2c_bus.c@210 PS1, Line 210: } else { else is not generally useful after a break or return
https://review.coreboot.org/c/coreboot/+/46290/1/src/include/device/i2c_bus.... File src/include/device/i2c_bus.h:
https://review.coreboot.org/c/coreboot/+/46290/1/src/include/device/i2c_bus.... PS1, Line 94: int i2c_dev_writeb_at16(struct device *, uint16_t off, uint8_t val); function definition argument 'struct device *' should also have an identifier name