EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45640 )
Change subject: mb/google/octopus/var/fleex: Add Wifi SAR table for LTE sku
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45640/1/src/mainboard/google/octopu...
File src/mainboard/google/octopus/variants/fleex/variant.c:
https://review.coreboot.org/c/coreboot/+/45640/1/src/mainboard/google/octopu...
PS1, Line 25: if (sku_id == 4)
From issue's comment, should change to
if (sku_id != 4)
return "fleex-sar.hex"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45640
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I086fa14a9f23e4a0fc0ef8085040219c932dbf17
Gerrit-Change-Number: 45640
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 23 Sep 2020 16:05:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment