Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39260 )
Change subject: soc/intel/tigerlake: Avoid NULL pointer dereference ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39260/2/src/soc/intel/tigerlake/fsp... File src/soc/intel/tigerlake/fsp_params_jsl.c:
https://review.coreboot.org/c/coreboot/+/39260/2/src/soc/intel/tigerlake/fsp... PS2, Line 166: } Don't you need an else block to set params->XdciEnable to 0 if dev is NULL?