HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42190 )
Change subject: nb/intel/i945: Use PCI bitwise ops
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42190/3/src/northbridge/intel/i945/...
File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/c/coreboot/+/42190/3/src/northbridge/intel/i945/...
PS3, Line 1720: (1 << 7) | (7 << 4));
Ah, I tried to factor this out but then saw it was impossible... […]
no
just add it in commit msg :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42190
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I181f69372829cf712fd72887b5f2c7134bfcf15a
Gerrit-Change-Number: 42190
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 08 Jun 2020 20:57:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment