Attention is currently required from: Nico Huber, Paul Menzel.
Sukumar Ghorai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75898?usp=email )
Change subject: mb/intel/mtlrvp: disable acpi timer for xtal shutdown
......................................................................
Patch Set 4: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75898/comment/c17f1511_2d13b417 :
PS3, Line 9: acpi timer need to disable for xtal shutdown
You missed the *be*.
Acknowledged
Commit Message:
https://review.coreboot.org/c/coreboot/+/75898/comment/dbe79330_d3077ab4 :
PS4, Line 11:
How did you test this? Please add a TEST= line.
Acknowledged
Patchset:
PS4:
The Kconfig help text says: […]
This config available across other platform too. not added 1st time.
Additional requirement must need to be meet in order to enter deepest sleep state, to save couple of milliwatts.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75898?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib87b7555217b6954fca98f95b86d03016cd9b783
Gerrit-Change-Number: 75898
Gerrit-PatchSet: 4
Gerrit-Owner: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 19 Jun 2023 16:52:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-MessageType: comment