Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44283 )
Change subject: mb/intel/jasperlake_rvp: Re-organize the FMAP layout
......................................................................
Patch Set 3:
Since I started a discussion on FMAP changes in CB:43790 a short discussion why this CL is still okay whereas 43790 may run into failure states:
We never update RW_LEGACY (even though the chromeos updater has _some_ provisions for that, I'm not sure we ever activated them) and so there are no changes during updates to any regions affected here (RW_LEGACY, RO_* and the FMAP itself). The only way to change these is to rewrite the entire flash which is safe.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44283
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia8bb381c31ddf76f3211f9d4ac5c8c18c27834b7
Gerrit-Change-Number: 44283
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Divagar Mohandass
divagar.mohandass@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 17 Aug 2020 06:37:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment