Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45695 )
Change subject: mb/purism/librem_skl: Enable and set SATA tuning params ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45695/1/src/mainboard/purism/librem... File src/mainboard/purism/librem_skl/romstage.c:
https://review.coreboot.org/c/coreboot/+/45695/1/src/mainboard/purism/librem... PS1, Line 72: mem_cfg->PchSataHsioRxGen3EqBoostMag[2] = 1; These are 1x SATA direct connect and 1x NVMe slot, right? In my guidelines for icfgctledatatap_fullrate (this setting), I see `1` is only valid for these two connectors and mSATA, and wanted to double-check.