Attention is currently required from: Christian Walter, Elyes Haouas, Felix Held, Fred Reitberger, Jason Glenesk, Julius Werner, Martin L Roth, Matt DeVillier, Nick Vaccaro, Subrata Banik, Yu-Ping Wu.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77536?usp=email )
Change subject: drivers/tpm: Make temp test value naming consistent
......................................................................
Patch Set 5:
(2 comments)
Patchset:
PS1:
forget*
Done
File src/drivers/i2c/tpm/cr50.c:
https://review.coreboot.org/c/coreboot/+/77536/comment/4d6e9c68_913a37fc :
PS1, Line 423: *did_vid
The coreboot standard for a continued line is typically two indent levels, not aligning with somethi […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77536?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If86805b39048800276ab90b7687644ec2a0d4bee
Gerrit-Change-Number: 77536
Gerrit-PatchSet: 5
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 05 Sep 2023 18:12:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr
Gerrit-MessageType: comment