Julien Viard de Galbert has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47340 )
Change subject: src/soc/intel/denverton_ns: Use improvement in coreboot since 4.9
......................................................................
Patch Set 3:
(2 comments)
Thanks for the review !
https://review.coreboot.org/c/coreboot/+/47340/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47340/2//COMMIT_MSG@8
PS2, Line 8:
Maybe sum up the changes here
Done
https://review.coreboot.org/c/coreboot/+/47340/2/src/soc/intel/denverton_ns/...
File src/soc/intel/denverton_ns/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/47340/2/src/soc/intel/denverton_ns/...
PS2, Line 5: cpu_microcode_bins += 3rdparty/intel-microcode/intel-ucode/06-5f-01
Can be removed. Same as in line 84.
oh, as the microcode was not enabled I didn't see this was already in, thanks!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47340
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc5ce91118c6052af23642fb3461f574cd888dea
Gerrit-Change-Number: 47340
Gerrit-PatchSet: 3
Gerrit-Owner: Julien Viard de Galbert
coreboot-review-ju@vdg.name
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 17 Nov 2020 22:18:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Gerrit-MessageType: comment