Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36908 )
Change subject: lib/fmap.c: Properly handle cache for !C_ENVIRONMENT_BOOTBLOCK
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36908/1/src/lib/fmap.c
File src/lib/fmap.c:
https://review.coreboot.org/c/coreboot/+/36908/1/src/lib/fmap.c@81
PS1, Line 81: if (!ENV_BOOTBLOCK && CONFIG(C_ENVIRONMENT_BOOTBLOCK)) {
This code returns on !ENV_ROMSTAGE_OR_BEFORE. Is there a use case I'm missing or do you prefer to make it more explicit here?
I guess technically all the cases would be covered, but I think the other version looks cleaner. Essentially this code is asking "if (!(this is the first stage we're executing))".
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36908
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7d70585b0c076707e73e20c2ed3f11e4c9ffdf37
Gerrit-Change-Number: 36908
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 18 Nov 2019 19:29:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment