Attention is currently required from: Vinod Polimera, Douglas Anderson. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52959 )
Change subject: drivers/sn65dsi86: Switch EDID reading to use "indirect mode" ......................................................................
Patch Set 4:
(3 comments)
File src/drivers/ti/sn65dsi86bridge/sn65dsi86bridge.c:
https://review.coreboot.org/c/coreboot/+/52959/comment/f7530189_54e3db3f PS4, Line 189: [I2C_RAW_WRITE] = I2C_OVER_AUX_WRITE_MOT_1, : [I2C_RAW_READ] = I2C_OVER_AUX_READ_MOT_1,
I haven't fully analyzed the side effects, but I _think_ that always using MOT=1 here isn't quite ri […]
Oh, cool, now I actually understand what MOT means. Couldn't find it explained in the datasheet. But you're right, upon closer inspection it does ask you to use a different command code for the last transfer.
https://review.coreboot.org/c/coreboot/+/52959/comment/7b55787d_40064bdb PS4, Line 200: i2c_writeb(bus, chip, SN_AUX_CMD_REG, (cmd[request] << 4))
I don't know if it maters, but kernel driver and datasheet show doing this _first_, before the setti […]
Done
https://review.coreboot.org/c/coreboot/+/52959/comment/f5c78749_da9361ca PS4, Line 220:
In the kernel driver, we check a whole bunch of extra status things here (timeout, short, and failed […]
*sigh*... I knew I was making a mistake when I decided to "quickly" write this myself instead of punting it off to Qualcomm. ^^ Okay, fine. Error handling added.