[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Support different SPD read type for each slot

[Philip Chen (Code Review)]

Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32513 )

Change subject: soc/intel/cannonlake: Support different SPD read type for each slot
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/#/c/32513/3/src/soc/intel/cannonlake/include/soc... 
File src/soc/intel/cannonlake/include/soc/cnl_memcfg_init.h:

https://review.coreboot.org/#/c/32513/3/src/soc/intel/cannonlake/include/soc... 
PS3, Line 43: mem_info_read_type
> It would be helpful to add comments indicating what each type means.

Done

https://review.coreboot.org/#/c/32513/3/src/soc/intel/cannonlake/include/soc... 
PS3, Line 52: spd_data_by
> A comment to explain how the data relates to the type would be helpful.

Done