Attention is currently required from: Sean Rhodes, Martin L Roth, Benjamin Doron, Stefan Reinauer, Arthur Heymans.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74176 )
Change subject: payloads/edk2: Set max variable size to 0x8000 for SMMSTORE
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS3:
Yeah, I recall that... Seems there's a maximum in this case too. Possibly `SMM_BLOCK_SIZE`.
sorry I was confusing the max variable size with the size of the store. I'm already overriding this in my tree =D
File payloads/external/edk2/Makefile:
https://review.coreboot.org/c/coreboot/+/74176/comment/0fb86898_9638aff8
PS4, Line 63: 0x400
this is supposed to represent the default value if not overridden, correct? So shouldn't it be 0x10000 ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74176
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10d2a5a0c1d729d83e0b62bb9430863317b883cc
Gerrit-Change-Number: 74176
Gerrit-PatchSet: 4
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 10 May 2023 23:46:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment