Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38706 )
Change subject: security/vboot: relocate vb2ex_abort and vb2ex_printf
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38706/1/src/security/vboot/vboot_co...
File src/security/vboot/vboot_common.c:
https://review.coreboot.org/c/coreboot/+/38706/1/src/security/vboot/vboot_co...
PS1, Line 76: }
void function return statements are not generally useful
Good point. Let's just remove that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38706
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica0103c5684b3d50ba7dc1b4c39559cb192efa81
Gerrit-Change-Number: 38706
Gerrit-PatchSet: 3
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 04 Feb 2020 10:33:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment