build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27421 )
Change subject: google/asuka: Add as a variant of glados
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/27421/3/src/mainboard/google/glados/variants...
File src/mainboard/google/glados/variants/asuka/include/variant/gpio.h:
https://review.coreboot.org/#/c/27421/3/src/mainboard/google/glados/variants...
PS3, Line 93: /* SRCCLKREQ0# */ PAD_CFG_GPI_ACPI_SCI(GPP_B5, NONE, DEEP, YES), /* TOUCHPAD WAKE */
line over 80 characters
--
To view, visit
https://review.coreboot.org/27421
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I591578fea2514a28c75177835807c3f250904577
Gerrit-Change-Number: 27421
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Youness Alaoui
snifikino@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 18 Jul 2018 20:27:14 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No