Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30822 )
Change subject: sb/intel/i82801gx: Detect if the southbridge supports AHCI
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/30822/5/src/southbridge/intel/i82801gx/sata....
File src/southbridge/intel/i82801gx/sata.c:
https://review.coreboot.org/#/c/30822/5/src/southbridge/intel/i82801gx/sata....
PS5, Line 75: ret = ahci_supported && config->sata_no_ahci;
What's the reason for having the sata_no_ahci option?
previously there was an option to set whatever mode you wanted on systems supporting AHCI which this option allows for. If that is not desirable, I can drop it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30822
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d9f4e63ae8b2862c422938f3103c44e761bcda4
Gerrit-Change-Number: 30822
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 17 Jan 2019 15:05:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment