Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43133 )
Change subject: soc/intel/baytrail: Add native refcode replacement ......................................................................
Patch Set 17: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/43133/17/src/soc/intel/baytrail/mod... File src/soc/intel/baytrail/modphy_table.c:
https://review.coreboot.org/c/coreboot/+/43133/17/src/soc/intel/baytrail/mod... PS17, Line 7: 0x000000a6 Port values are u8, drop the leading zeroes?
https://review.coreboot.org/c/coreboot/+/43133/17/src/soc/intel/baytrail/mod... PS17, Line 7: 0x00000000, 0x00000001 Same story for read and write opcodes
https://review.coreboot.org/c/coreboot/+/43133/17/src/soc/intel/baytrail/ref... File src/soc/intel/baytrail/refcode_native.c:
https://review.coreboot.org/c/coreboot/+/43133/17/src/soc/intel/baytrail/ref... PS17, Line 40: (char *) (char *) Duplicate casts?