Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41081 )
Change subject: soc/intel/cannonlake: Add VrPowerDeliveryDesign to chip options
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41081/1/src/soc/intel/cannonlake/ch...
File src/soc/intel/cannonlake/chip.h:
https://review.coreboot.org/c/coreboot/+/41081/1/src/soc/intel/cannonlake/ch...
PS1, Line 417: #if !CONFIG(SOC_INTEL_COMETLAKE)
I felt like this is the general rule in cannonlakefolder - to exclude COMETLAKE instead of including […]
I just mark this to be resolved if thats fine w/ you.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41081
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I89b8dceb40fa6a9dc67b218e91bf728ff928b5a0
Gerrit-Change-Number: 41081
Gerrit-PatchSet: 3
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 06 May 2020 17:29:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Christian Walter
christian.walter@9elements.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment