Attention is currently required from: Martin Roth, Paul Fagerburg, Julius Werner, Jan Dabros. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51976 ) Change subject: tests: Add lib/uuid-test test case ...................................................................... Patch Set 3: (1 comment) File tests/lib/uuid-test.c: https://review.coreboot.org/c/coreboot/+/51976/comment/835b6045_83afe490 PS2, Line 83: assert_int_equal(guid.b[7] - guid_copy.b[7]
would this be better as "assert_int_not_equal(0," so that you're just checking that the compare fail […] You are right. I was convinced that it really does return exact difference. I looked into documentation and it gives no guarantee of that.
-- To view, visit https://review.coreboot.org/c/coreboot/+/51976 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7f8498ad3d9d0d68b34aa0b48daca60545ec3f4e Gerrit-Change-Number: 51976 Gerrit-PatchSet: 3 Gerrit-Owner: Jakub Czapiga <jacz@semihalf.com> Gerrit-Reviewer: Jan Dabros <jsd@semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Attention: Martin Roth <martinroth@google.com> Gerrit-Attention: Paul Fagerburg <pfagerburg@chromium.org> Gerrit-Attention: Julius Werner <jwerner@chromium.org> Gerrit-Attention: Jan Dabros <jsd@semihalf.com> Gerrit-Comment-Date: Thu, 01 Apr 2021 08:04:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Fagerburg <pfagerburg@chromium.org> Gerrit-MessageType: comment