[coreboot-gerrit] Change in coreboot[master]: soc/nvidia/tegra124: Fix null pointer and logic bug

[Jacob Garber (Code Review)]

Hello Julius Werner, Tim Wawrzynczak, build bot (Jenkins), Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35904

to look at the new patch set (#2).

Change subject: soc/nvidia/tegra124: Fix null pointer and logic bug
......................................................................

soc/nvidia/tegra124: Fix null pointer and logic bug

Commit 680027edf6 fixed a null dereference and logic bug in the tegra210
spi code:

soc/nvidia/tegra210: Fix potential NULL pointer dereference

Recent Coverity scan indicated potential NULL deference; if either
    spi->dma_in or spi->dma_out are NULL, the fifo_error() check could
    dereference a NULL pointer.

Also fixed what appears to be a logic bug for the spi->dma_out case,
    where it was using the todo (count) from spi->dma_in.

Coverity is warning about the same problem for tegra124, so apply the
same fix there. Also, add braces around a while statement.

Change-Id: I6a7403417ee83b703cf4ca495129f73c66691ea9
Signed-off-by: Jacob Garber 
Found-by: Coverity CID 124183, 124185
---
M src/soc/nvidia/tegra124/spi.c
1 file changed, 9 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/35904/2