Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Angel Pons, Jianjun Wang. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63019 )
Change subject: soc/mediatek: Add early_init for passing data across sessions ......................................................................
Patch Set 7:
(8 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63019/comment/ec795edf_1bf7642a PS7, Line 7: sessions stages
https://review.coreboot.org/c/coreboot/+/63019/comment/c0d066da_60dcc3ea PS7, Line 9: Passing pcie timestamp from bootblock stage to ram stage, it can be used : for other modules if they needs to passing data across sessions. Add support for "early_init_data" region, which can be used to store data initialized in an early stage (such as bootblock), and retrieve it in later stages (such as ramstage).
File src/soc/mediatek/common/early_init.c:
https://review.coreboot.org/c/coreboot/+/63019/comment/5c979dbd_cd75cc8c PS7, Line 10: assert(sizeof(struct early_init_data) <= REGION_SIZE(early_init_data)); Does it compile if we use _Static_assert() in early_init.h?
https://review.coreboot.org/c/coreboot/+/63019/comment/d120f0ee_65797b22 PS7, Line 16: init data
https://review.coreboot.org/c/coreboot/+/63019/comment/7e90a380_9637c428 PS7, Line 26: init data
https://review.coreboot.org/c/coreboot/+/63019/comment/d2eb2d29_992c5a56 PS7, Line 36: init data
https://review.coreboot.org/c/coreboot/+/63019/comment/783b7cfd_2b1b1441 PS7, Line 44: was never done data was never saved
File src/soc/mediatek/common/include/soc/early_init.h:
https://review.coreboot.org/c/coreboot/+/63019/comment/3fa3b044_604c7a43 PS7, Line 19: saved_time init_time