Tim Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45408 )
Change subject: mb/ocp/deltalake: Override uart base address via VPD variable
......................................................................
Patch Set 15:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45408/14/src/mainboard/ocp/deltalak...
File src/mainboard/ocp/deltalake/romstage.c:
https://review.coreboot.org/c/coreboot/+/45408/14/src/mainboard/ocp/deltalak...
PS14, Line 49: default
get_uart_for_console should check the vpd setting and return the default if the value is out of rang […]
Done
https://review.coreboot.org/c/coreboot/+/45408/14/src/mainboard/ocp/deltalak...
File src/mainboard/ocp/deltalake/uartio_vpd.c:
https://review.coreboot.org/c/coreboot/+/45408/14/src/mainboard/ocp/deltalak...
PS14, Line 18: COREBOOT_UART_IO_DEFAULT
no need for the else, already set above.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45408
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55a85d6f137ef1aba95466e7b094740b685bf9bd
Gerrit-Change-Number: 45408
Gerrit-PatchSet: 15
Gerrit-Owner: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
philipp.deppenwiese@9elements.com
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Marc Jones
marc@marcjonesconsulting.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 21 Dec 2020 02:38:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marc Jones
marc@marcjonesconsulting.com
Gerrit-MessageType: comment