Attention is currently required from: Angel Pons, Cliff Huang, David Milosevic, Felix Singer, Lance Zhao, Lean Sheng Tan, Martin L Roth, Maximilian Brune, Naresh Solanki, Nico Huber, Patrick Rudolph, Tim Wawrzynczak.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79096?usp=email )
Change subject: acpi: Enable 64bit ECAM resource
......................................................................
Patch Set 5:
(1 comment)
File src/acpi/dsdt_top.asl:
https://review.coreboot.org/c/coreboot/+/79096/comment/92b1e8e3_0845e0bc :
PS5, Line 66: 0x0000000000000000, // Granularity
I am not sure but granularity seems to refer to the alignment. Does the ECAM base and limit have no alignment constraints?
On Intel it needs to be aligned to it's size, but IDK on others. However here it's reported as a MinFixed & MaxFixed. You don't care about granularity as you tell the OS not to move it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79096?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idb049d848f2311e27df5279a10c33f9fab259c08
Gerrit-Change-Number: 79096
Gerrit-PatchSet: 5
Gerrit-Owner: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: David Milosevic
David.Milosevic@9elements.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Attention: David Milosevic
David.Milosevic@9elements.com
Gerrit-Comment-Date: Fri, 24 Nov 2023 05:28:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-MessageType: comment