Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32538 )
Change subject: mb/google/sarien/variants/arcada: Update thermal configuration for DPTF
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32538/1/src/mainboard/google/sarien/variants...
File src/mainboard/google/sarien/variants/arcada/include/variant/acpi/dptf.asl:
https://review.coreboot.org/#/c/32538/1/src/mainboard/google/sarien/variants...
PS1, Line 34: 37
How did you arrive to this number ? I feel this number is very low. […]
Tested with this change and it does not impact performance of the system. So, looks good to me.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32538
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia8024a69547a569d288e02931190a98676eeaab4
Gerrit-Change-Number: 32538
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Hsieh
mike_hsieh@wistron.corp-partner.google.com
Gerrit-Reviewer: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Mike Hsieh
mike_hsieh@wistron.corp-partner.google.com
Gerrit-Reviewer: Nathan Chen
nathan_chen@wistron.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Sumeet Pawnikar
sumeet.r.pawnikar@intel.corp-partner.google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 08 May 2019 05:24:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-MessageType: comment