Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42234 )
Change subject: libpayload: Fix potential compilation issues
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42234/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42234/2//COMMIT_MSG@9
PS2, Line 9: The include chain can define one of the macros (BIT, MIN, MAX are all
I still think this is the better, more robust approach (and in the same time fix every time it's mis […]
I'm okay with putting this in with a #warning directive if you want to, that may be useful for other payloads which don't care about doing things the right way as much. Note that for depthcharge, all warnings are treated as errors, so it would still prevent compilation there (as I think it should).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42234
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e1c1f8e75b752bc3d78e0c843866d0144b82b2a
Gerrit-Change-Number: 42234
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Levin
levinale@google.com
Gerrit-Reviewer: Alex Levin
levinale@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 09 Jun 2020 23:50:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alex Levin
levinale@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment