Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47430 )
Change subject: soc/intel/common: Add Kconfig for CSE RW firmware version
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47430/4/src/soc/intel/common/block/...
File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/47430/4/src/soc/intel/common/block/...
PS4, Line 49: firmware
nit: Rest of the Kconfigs refer to this as blob. Maybe use the same here? […]
I see that CSE RW version is populated in the first few bytes of CSE_RW_FILE. Can the version be extracted from there?
I am concerned that we are manually inputting CSE RW version in multiple places. Once while generating the CSE RW File and then later we have to update this kconfig.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47430
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62691ee3ede7d4cd21f821381f5d1519f9061fd9
Gerrit-Change-Number: 47430
Gerrit-PatchSet: 4
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 11 Nov 2020 23:08:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment