Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Alex Levin, Julius Werner, Jan Dabros. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62474 )
Change subject: util/cbmem: Add FlameGraph-compatible timestamps output ......................................................................
Patch Set 16:
(4 comments)
File src/commonlib/include/commonlib/timestamp_serialized.h:
https://review.coreboot.org/c/coreboot/+/62474/comment/5382825d_4223d96a PS7, Line 454: uint32_t id_end;
I think the zeroes are fine. […]
Oh, right. There is no need to keep it :)
File util/cbmem/cbmem.c:
https://review.coreboot.org/c/coreboot/+/62474/comment/fbd1c459_fab3fdc8 PS15, Line 601: possible_match = timestamp_ids[i].id_end;
This should also have a break;
Done
https://review.coreboot.org/c/coreboot/+/62474/comment/f0fb5f6f_b11f5492 PS15, Line 643: = 0,
nit: this enum doesn't really need explicitly assigned values. […]
Yes, explicit values seem to be unnecessary here. Thanks :)
https://review.coreboot.org/c/coreboot/+/62474/comment/4c46cae3_6cc6ddf4 PS15, Line 1580: timestamp_type != TIMESTAMPS_PRINT_NONE : ? timestamp_type : : TIMESTAMPS_PRINT_NORMAL
Oh, right, I didn't consider how ugly this would get with that... […]
Looks nice :)