Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37854 )
Change subject: src: Remove blank acpi_tables source files ......................................................................
src: Remove blank acpi_tables source files
Due to build rules, dummy acpi_tables source files were added in many mainboards. With commit 1e83e5c61a3aa98f58f7d8cbf8d1eb9532896cc3 ("src/arch/x86: Build mainboard acpi_tables source if present"), the build system will build mainboard acpi_tables only if present. Remove the dummy/empty/blank acpi_tables source files.
BUG=None TEST=Build test with some google mainboards.
Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com Change-Id: I0cef34368e2e5f5e3b946b22658ca10c7caad90a Reviewed-on: https://review.coreboot.org/c/coreboot/+/37854 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-by: Patrick Rudolph siro@das-labor.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- D src/mainboard/amd/gardenia/acpi_tables.c D src/mainboard/amd/padmelon/acpi_tables.c D src/mainboard/apple/macbookair4_2/acpi_tables.c D src/mainboard/asrock/h110m/acpi_tables.c D src/mainboard/facebook/monolith/acpi_tables.c D src/mainboard/google/dragonegg/acpi_tables.c D src/mainboard/google/drallion/acpi_tables.c D src/mainboard/google/eve/acpi_tables.c D src/mainboard/google/fizz/acpi_tables.c D src/mainboard/google/glados/acpi_tables.c D src/mainboard/google/hatch/acpi_tables.c D src/mainboard/google/kahlee/acpi_tables.c D src/mainboard/google/octopus/acpi_tables.c D src/mainboard/google/poppy/acpi_tables.c D src/mainboard/google/reef/acpi_tables.c D src/mainboard/google/sarien/acpi_tables.c D src/mainboard/intel/apollolake_rvp/acpi_tables.c D src/mainboard/intel/cannonlake_rvp/acpi_tables.c D src/mainboard/intel/coffeelake_rvp/acpi_tables.c D src/mainboard/intel/glkrvp/acpi_tables.c D src/mainboard/intel/icelake_rvp/acpi_tables.c D src/mainboard/intel/kblrvp/acpi_tables.c D src/mainboard/intel/kunimitsu/acpi_tables.c D src/mainboard/intel/leafhill/acpi_tables.c D src/mainboard/intel/minnow3/acpi_tables.c D src/mainboard/intel/saddlebrook/acpi_tables.c D src/mainboard/purism/librem_skl/acpi_tables.c D src/mainboard/razer/blade_stealth_kbl/acpi_tables.c D src/mainboard/siemens/mc_apl1/acpi_tables.c D src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c D src/mainboard/up/squared/acpi_tables.c 31 files changed, 0 insertions(+), 93 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Furquan Shaikh: Looks good to me, approved HAOUAS Elyes: Looks good to me, approved Patrick Rudolph: Looks good to me, approved Wim Vervoorn: Looks good to me, but someone else must approve Frans Hendriks: Looks good to me, approved
diff --git a/src/mainboard/amd/gardenia/acpi_tables.c b/src/mainboard/amd/gardenia/acpi_tables.c deleted file mode 100644 index 8d4d1cf..0000000 --- a/src/mainboard/amd/gardenia/acpi_tables.c +++ /dev/null @@ -1,14 +0,0 @@ -/* - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* - * Blank file required by build system assumptions of this file being present. - */ diff --git a/src/mainboard/amd/padmelon/acpi_tables.c b/src/mainboard/amd/padmelon/acpi_tables.c deleted file mode 100644 index e06f6a6..0000000 --- a/src/mainboard/amd/padmelon/acpi_tables.c +++ /dev/null @@ -1,3 +0,0 @@ -/* - * Blank file required by build system assumptions of this file being present. - */ diff --git a/src/mainboard/apple/macbookair4_2/acpi_tables.c b/src/mainboard/apple/macbookair4_2/acpi_tables.c deleted file mode 100644 index 49a12e5..0000000 --- a/src/mainboard/apple/macbookair4_2/acpi_tables.c +++ /dev/null @@ -1,2 +0,0 @@ -/* No license required */ -/* dummy */ diff --git a/src/mainboard/asrock/h110m/acpi_tables.c b/src/mainboard/asrock/h110m/acpi_tables.c deleted file mode 100644 index e69de29..0000000 --- a/src/mainboard/asrock/h110m/acpi_tables.c +++ /dev/null diff --git a/src/mainboard/facebook/monolith/acpi_tables.c b/src/mainboard/facebook/monolith/acpi_tables.c deleted file mode 100644 index e69de29..0000000 --- a/src/mainboard/facebook/monolith/acpi_tables.c +++ /dev/null diff --git a/src/mainboard/google/dragonegg/acpi_tables.c b/src/mainboard/google/dragonegg/acpi_tables.c deleted file mode 100644 index e06f6a6..0000000 --- a/src/mainboard/google/dragonegg/acpi_tables.c +++ /dev/null @@ -1,3 +0,0 @@ -/* - * Blank file required by build system assumptions of this file being present. - */ diff --git a/src/mainboard/google/drallion/acpi_tables.c b/src/mainboard/google/drallion/acpi_tables.c deleted file mode 100644 index e69de29..0000000 --- a/src/mainboard/google/drallion/acpi_tables.c +++ /dev/null diff --git a/src/mainboard/google/eve/acpi_tables.c b/src/mainboard/google/eve/acpi_tables.c deleted file mode 100644 index e69de29..0000000 --- a/src/mainboard/google/eve/acpi_tables.c +++ /dev/null diff --git a/src/mainboard/google/fizz/acpi_tables.c b/src/mainboard/google/fizz/acpi_tables.c deleted file mode 100644 index e69de29..0000000 --- a/src/mainboard/google/fizz/acpi_tables.c +++ /dev/null diff --git a/src/mainboard/google/glados/acpi_tables.c b/src/mainboard/google/glados/acpi_tables.c deleted file mode 100644 index e69de29..0000000 --- a/src/mainboard/google/glados/acpi_tables.c +++ /dev/null diff --git a/src/mainboard/google/hatch/acpi_tables.c b/src/mainboard/google/hatch/acpi_tables.c deleted file mode 100644 index e69de29..0000000 --- a/src/mainboard/google/hatch/acpi_tables.c +++ /dev/null diff --git a/src/mainboard/google/kahlee/acpi_tables.c b/src/mainboard/google/kahlee/acpi_tables.c deleted file mode 100644 index 8d4d1cf..0000000 --- a/src/mainboard/google/kahlee/acpi_tables.c +++ /dev/null @@ -1,14 +0,0 @@ -/* - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* - * Blank file required by build system assumptions of this file being present. - */ diff --git a/src/mainboard/google/octopus/acpi_tables.c b/src/mainboard/google/octopus/acpi_tables.c deleted file mode 100644 index e06f6a6..0000000 --- a/src/mainboard/google/octopus/acpi_tables.c +++ /dev/null @@ -1,3 +0,0 @@ -/* - * Blank file required by build system assumptions of this file being present. - */ diff --git a/src/mainboard/google/poppy/acpi_tables.c b/src/mainboard/google/poppy/acpi_tables.c deleted file mode 100644 index e69de29..0000000 --- a/src/mainboard/google/poppy/acpi_tables.c +++ /dev/null diff --git a/src/mainboard/google/reef/acpi_tables.c b/src/mainboard/google/reef/acpi_tables.c deleted file mode 100644 index 8d4d1cf..0000000 --- a/src/mainboard/google/reef/acpi_tables.c +++ /dev/null @@ -1,14 +0,0 @@ -/* - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* - * Blank file required by build system assumptions of this file being present. - */ diff --git a/src/mainboard/google/sarien/acpi_tables.c b/src/mainboard/google/sarien/acpi_tables.c deleted file mode 100644 index e69de29..0000000 --- a/src/mainboard/google/sarien/acpi_tables.c +++ /dev/null diff --git a/src/mainboard/intel/apollolake_rvp/acpi_tables.c b/src/mainboard/intel/apollolake_rvp/acpi_tables.c deleted file mode 100644 index 8d4d1cf..0000000 --- a/src/mainboard/intel/apollolake_rvp/acpi_tables.c +++ /dev/null @@ -1,14 +0,0 @@ -/* - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* - * Blank file required by build system assumptions of this file being present. - */ diff --git a/src/mainboard/intel/cannonlake_rvp/acpi_tables.c b/src/mainboard/intel/cannonlake_rvp/acpi_tables.c deleted file mode 100644 index 3b44754..0000000 --- a/src/mainboard/intel/cannonlake_rvp/acpi_tables.c +++ /dev/null @@ -1 +0,0 @@ -/* Nothing here */ diff --git a/src/mainboard/intel/coffeelake_rvp/acpi_tables.c b/src/mainboard/intel/coffeelake_rvp/acpi_tables.c deleted file mode 100644 index 3b44754..0000000 --- a/src/mainboard/intel/coffeelake_rvp/acpi_tables.c +++ /dev/null @@ -1 +0,0 @@ -/* Nothing here */ diff --git a/src/mainboard/intel/glkrvp/acpi_tables.c b/src/mainboard/intel/glkrvp/acpi_tables.c deleted file mode 100644 index e06f6a6..0000000 --- a/src/mainboard/intel/glkrvp/acpi_tables.c +++ /dev/null @@ -1,3 +0,0 @@ -/* - * Blank file required by build system assumptions of this file being present. - */ diff --git a/src/mainboard/intel/icelake_rvp/acpi_tables.c b/src/mainboard/intel/icelake_rvp/acpi_tables.c deleted file mode 100644 index 3b44754..0000000 --- a/src/mainboard/intel/icelake_rvp/acpi_tables.c +++ /dev/null @@ -1 +0,0 @@ -/* Nothing here */ diff --git a/src/mainboard/intel/kblrvp/acpi_tables.c b/src/mainboard/intel/kblrvp/acpi_tables.c deleted file mode 100644 index e69de29..0000000 --- a/src/mainboard/intel/kblrvp/acpi_tables.c +++ /dev/null diff --git a/src/mainboard/intel/kunimitsu/acpi_tables.c b/src/mainboard/intel/kunimitsu/acpi_tables.c deleted file mode 100644 index e69de29..0000000 --- a/src/mainboard/intel/kunimitsu/acpi_tables.c +++ /dev/null diff --git a/src/mainboard/intel/leafhill/acpi_tables.c b/src/mainboard/intel/leafhill/acpi_tables.c deleted file mode 100644 index 8d4d1cf..0000000 --- a/src/mainboard/intel/leafhill/acpi_tables.c +++ /dev/null @@ -1,14 +0,0 @@ -/* - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* - * Blank file required by build system assumptions of this file being present. - */ diff --git a/src/mainboard/intel/minnow3/acpi_tables.c b/src/mainboard/intel/minnow3/acpi_tables.c deleted file mode 100644 index e06f6a6..0000000 --- a/src/mainboard/intel/minnow3/acpi_tables.c +++ /dev/null @@ -1,3 +0,0 @@ -/* - * Blank file required by build system assumptions of this file being present. - */ diff --git a/src/mainboard/intel/saddlebrook/acpi_tables.c b/src/mainboard/intel/saddlebrook/acpi_tables.c deleted file mode 100644 index e69de29..0000000 --- a/src/mainboard/intel/saddlebrook/acpi_tables.c +++ /dev/null diff --git a/src/mainboard/purism/librem_skl/acpi_tables.c b/src/mainboard/purism/librem_skl/acpi_tables.c deleted file mode 100644 index e69de29..0000000 --- a/src/mainboard/purism/librem_skl/acpi_tables.c +++ /dev/null diff --git a/src/mainboard/razer/blade_stealth_kbl/acpi_tables.c b/src/mainboard/razer/blade_stealth_kbl/acpi_tables.c deleted file mode 100644 index e69de29..0000000 --- a/src/mainboard/razer/blade_stealth_kbl/acpi_tables.c +++ /dev/null diff --git a/src/mainboard/siemens/mc_apl1/acpi_tables.c b/src/mainboard/siemens/mc_apl1/acpi_tables.c deleted file mode 100644 index e06f6a6..0000000 --- a/src/mainboard/siemens/mc_apl1/acpi_tables.c +++ /dev/null @@ -1,3 +0,0 @@ -/* - * Blank file required by build system assumptions of this file being present. - */ diff --git a/src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c b/src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c deleted file mode 100644 index e69de29..0000000 --- a/src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c +++ /dev/null diff --git a/src/mainboard/up/squared/acpi_tables.c b/src/mainboard/up/squared/acpi_tables.c deleted file mode 100644 index e69de29..0000000 --- a/src/mainboard/up/squared/acpi_tables.c +++ /dev/null