[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Allow toggling of GMM in devicetree in Gemini Lake

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39579 )

Change subject: soc/intel/apollolake: Allow toggling of GMM in devicetree in Gemini Lake
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39579/1/src/soc/intel/apollolake/ch... 
File src/soc/intel/apollolake/chip.c:

https://review.coreboot.org/c/coreboot/+/39579/1/src/soc/intel/apollolake/ch... 
PS1, Line 637: 	silconfig->Gmm = dev ? dev->enabled : 0;
> Considering this function is glk_fsk_silicon.. […]

Is it required on all the GLK devices or is it required for select variants?

If only for select variants, then no need to print an error and enable it only on those variants.