Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35612 )
Change subject: mb/google/kukui: Extend FMAP to 8MB layout ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35612/6/src/mainboard/google/kukui/... File src/mainboard/google/kukui/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/35612/6/src/mainboard/google/kukui/... PS6, Line 40: RW_SHARED 36K {
nit: why not just leave this unspecified...
I tried that before, but the fmt tool currently seem to not support having two unspecified region in same level, even if one can be decided by its children regions.
https://review.coreboot.org/c/coreboot/+/35612/6/src/mainboard/google/kukui/... PS6, Line 42: RW_UNUSED
...don't have this...
RW_SHARED has special meaning and will be copied on A/B AU so I'd like to reserve some space for it. Let me put that in the fmd comment.
https://review.coreboot.org/c/coreboot/+/35612/6/src/mainboard/google/kukui/... PS6, Line 44: RW_LEGACY(CBFS) 1M # Minimal 1M.
... […]
I'd like the make the regions in more similar size so if we have to move or revise in future (so updating will be easier).