Hello Edward O'Callaghan, Marshall Dawson, Paul Menzel, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35020
to look at the new patch set (#4).
Change subject: soc/amd/picasso: Use new common SPI code ......................................................................
soc/amd/picasso: Use new common SPI code
Use the new SPI code from common folder, delete spi.c. SPI related macros must be single defined, in southbridge.h if they are used by files other than the common SPI code, fch_spi.h if they are only used by the common SPI code. The only exception is SPI_FIFO_DEPTH which must be in southbridge.h, because it can change between SOC.
BUG=b:136595978 TEST=None, code already tested with grunt.
Change-Id: I68008ce076d348adbdabf7b49cec8783dd7134b4 Signed-off-by: Richard Spiegel richard.spiegel@silverbackltd.com --- M src/soc/amd/picasso/Kconfig M src/soc/amd/picasso/Makefile.inc M src/soc/amd/picasso/include/soc/southbridge.h D src/soc/amd/picasso/spi.c 4 files changed, 2 insertions(+), 207 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/35020/4