[coreboot-gerrit] Change in coreboot[master]: arch/x86/smbios: Update SMBIOS type 0 ec version

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45138 )

Change subject: arch/x86/smbios: Update SMBIOS type 0 ec version
......................................................................

arch/x86/smbios: Update SMBIOS type 0 ec version

Update embedded controller firmware version for SMBIOS type 0.

TEST=Execute "dmidecode -t 0" to check if the ec version is correct

Signed-off-by: Tim Chu 
Change-Id: Ibd5ee27a1b8fa4e5bc66e359d3b62e052e19e8a2
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45138
Tested-by: build bot (Jenkins) 
Reviewed-by: Jonathan Zhang 
Reviewed-by: Patrick Rudolph 
Reviewed-by: Angel Pons 
---
M src/arch/x86/smbios.c
M src/arch/x86/smbios_defaults.c
M src/include/smbios.h
3 files changed, 10 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Rudolph: Looks good to me, approved
  Angel Pons: Looks good to me, but someone else must approve
  Jonathan Zhang: Looks good to me, but someone else must approve

diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c
index 2cf4ac5..2995ece 100644
--- a/src/arch/x86/smbios.c
+++ b/src/arch/x86/smbios.c
@@ -430,6 +430,8 @@
    t->system_bios_major_release = coreboot_major_revision;
    t->system_bios_minor_release = coreboot_minor_revision;

+	smbios_ec_revision(&t->ec_major_release, &t->ec_minor_release);
+
    t->bios_characteristics =
    	BIOS_CHARACTERISTICS_PCI_SUPPORTED |
    	BIOS_CHARACTERISTICS_SELECTABLE_BOOT |
diff --git a/src/arch/x86/smbios_defaults.c b/src/arch/x86/smbios_defaults.c
index 22ce7a5..4d8883f3 100644
--- a/src/arch/x86/smbios_defaults.c
+++ b/src/arch/x86/smbios_defaults.c
@@ -63,6 +63,12 @@
    return SMBIOS_BOARD_TYPE_UNKNOWN;
 }

+__weak void smbios_ec_revision(uint8_t *ec_major_revision, uint8_t *ec_minor_revision)
+{
+	*ec_major_revision = 0x0;
+	*ec_minor_revision = 0x0;
+}
+
 /*
  * System Enclosure or Chassis Types as defined in SMBIOS specification.
  * The default value is SMBIOS_ENCLOSURE_DESKTOP (0x03) but laptop,
diff --git a/src/include/smbios.h b/src/include/smbios.h
index 521339e..8033d6c 100644
--- a/src/include/smbios.h
+++ b/src/include/smbios.h
@@ -54,6 +54,8 @@
 const char *smbios_chassis_serial_number(void);
 const char *smbios_processor_serial_number(void);

+void smbios_ec_revision(uint8_t *ec_major_revision, uint8_t *ec_minor_revision);
+
 unsigned int smbios_processor_external_clock(void);
 unsigned int smbios_processor_characteristics(void);
 struct cpuid_result;