build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44723 )
Change subject: soc/mediatek/mt8192: set dramc dqsosc shuffle setting ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/c/coreboot/+/44723/1/src/soc/mediatek/mt8192/dra... File src/soc/mediatek/mt8192/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/44723/1/src/soc/mediatek/mt8192/dra... PS1, Line 2797: static void dramc_start_dqsosc(const struct ddr_cali* cali) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/44723/1/src/soc/mediatek/mt8192/dra... PS1, Line 2830: static u16 dramc_dqsosc_auto(const struct ddr_cali* cali) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/44723/1/src/soc/mediatek/mt8192/dra... PS1, Line 2892: void dramc_dqsosc_set_mr18_mr19(const struct ddr_cali* cali, "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/44723/1/src/soc/mediatek/mt8192/dra... PS1, Line 2929: void dqsosc_shu_settings(const struct ddr_cali* cali, "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/44723/1/src/soc/mediatek/mt8192/dra... PS1, Line 2935: u8 dqsosc_cr_cnt = 0, is_div4 = 0, round_up= 0; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/44723/1/src/soc/mediatek/mt8192/dra... PS1, Line 2993: round_up = (prd_cnt_tmp + dqsosc_cr_cnt *100 / 16) % 100; need consistent spacing around '*' (ctx:WxV)