Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38737 )
Change subject: soc/tigerlake: Update FSP UPDs to turn on USB4/TBT
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38737/3/src/soc/intel/tigerlake/chi...
File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/38737/3/src/soc/intel/tigerlake/chi...
PS3, Line 235: USB4/TBT
should these be structured as an array like ITbtPcieRootPortEn?
This is a different config than ITbtPcieRootPortEn...that one is in Fsps the one that is being changed my this config is in Fspm and is for the bridge not the root port if my understanding of the to configs is correct
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38737
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f020e20fa8e9fd1ac69d883f4dc1fcbb330a3bf
Gerrit-Change-Number: 38737
Gerrit-PatchSet: 3
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-CC: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Comment-Date: Tue, 17 Mar 2020 17:09:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Gerrit-MessageType: comment