Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35303 )
Change subject: mb/google/drallion: Enable 360 sensor detection ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35303/3/src/mainboard/google/dralli... File src/mainboard/google/drallion/chromeos.c:
https://review.coreboot.org/c/coreboot/+/35303/3/src/mainboard/google/dralli... PS3, Line 28: /* Sensor detection pin */ : #define SENSOR_DET_360 GPP_H5 Put this in gpio.h
https://review.coreboot.org/c/coreboot/+/35303/3/src/mainboard/google/dralli... PS3, Line 134: gpio_input(SENSOR_DET_360); I think this should be set up in gpio.c