Attention is currently required from: Nico Huber, Subrata Banik, Johnny Lin, Christian Walter, Andrey Petrov, Tim Chu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69509 )
Change subject: Revert "src/arch/x86: Use core apic id to get cpu_index()"
......................................................................
Patch Set 4:
(1 comment)
File src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c:
https://review.coreboot.org/c/coreboot/+/69509/comment/a629a6b9_09a552af
PS4, Line 69:
: if (!cpu_info())
Do we need these ones actually? Can we assume this only runs on the BSP?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69509
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a40156ba275b572d7d1913d8c17c24b4c8f6d78
Gerrit-Change-Number: 69509
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Thu, 17 Nov 2022 19:35:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment