Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
David Wu has posted comments on this change by David Wu. ( https://review.coreboot.org/c/coreboot/+/86540?usp=email )
Change subject: mb/google/nissa/var/dirks: Add fw_config probe for WIFI Type
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/dirks/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/86540/comment/1208337a_8cad4eb8?usp... :
PS1, Line 7: WIFI_ALL
oh I mean change to WIFI_DEFAULT is better.
It is to align with the project configurations (config.star). Thanks.
https://chrome-internal.googlesource.com/chromeos/project/nissa/dirks/+/refs...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86540?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaefda61e4929d48f02ce7190e9e45d70b32b75e3
Gerrit-Change-Number: 86540
Gerrit-PatchSet: 1
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 21 Feb 2025 05:43:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com