V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47523 )
Change subject: soc/intel/common: Add Kconfig to enable the CSE FW Update feature
......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47523/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47523/3//COMMIT_MSG@10
PS3, Line 10: teh
the
Done
https://review.coreboot.org/c/coreboot/+/47523/3//COMMIT_MSG@12
PS3, Line 12:
Can you also add a comment here indicating that this is effectively disabling CSE FW update feature […]
Done
https://review.coreboot.org/c/coreboot/+/47523/3/src/soc/intel/common/block/...
File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/47523/3/src/soc/intel/common/block/...
PS3, Line 45: if SOC_INTEL_CSE_RW_UPDATE
This should also cover SOC_INTEL_CSE_FMAP_NAME and SOC_INTEL_CSE_RW_CBFS_NAME. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47523
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12810031224f79aba8a4057725ae0ed5a9b36d7e
Gerrit-Change-Number: 47523
Gerrit-PatchSet: 4
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 15 Nov 2020 15:17:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment