Attention is currently required from: Raul Rangel, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74111 )
Change subject: mb/google/myst: Enable AP <-> GSC communication ......................................................................
Patch Set 6:
(3 comments)
File src/mainboard/google/myst/Kconfig:
https://review.coreboot.org/c/coreboot/+/74111/comment/f159d9d6_80fff0bd PS4, Line 38: default 0x03
Should this be 0x2?
Yup, good catch. Thanks!
File src/mainboard/google/myst/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/74111/comment/e8f532be_eb57a549 PS4, Line 136: device i2c 50 on end
Should this be GPIO_84?
Yup, good catch. Thanks
File src/mainboard/google/myst/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/74111/comment/7535e595_e78d9e3c PS5, Line 182: PAD_INT(GPIO_18, PULL_NONE, EDGE_LOW, STATUS_DELIVERY),
Doh! Missed this one too: GPIO_84 […]
The individual tables are used for defining or enabling different features at different times. It may be useful for example to enable the TPM early, or wait until a later boot phase to turn WLAN on. Agreed that using the GPIO numbers leads to confusion. We could alternatively define named constants for the pin functions and use those. They probably vary less design to design.